--------------------- PatchSet 6909 Date: 2008/02/22 21:28:28 Author: amosjeffries Branch: cleanup Tag: (none) Log: Add .h testing of src/repl/* files Members: NOTES:1.1->1.1.2.1 NOTES-cleanup:1.1.2.3->1.1.2.4(DEAD) src/Makefile.am:1.138.2.5->1.138.2.6 src/repl/Makefile.am:1.6->1.6.42.1 --- /dev/null Sat Feb 23 01:23:02 2008 +++ squid3/NOTES Sat Feb 23 01:23:02 2008 @@ -0,0 +1,37 @@ + +TODO List for the cleanup branch operations. + +* Add automatic testing for header dependency + DONE- script to perform universal include unit-test for .h files + UNDERWAY - link to automatic unit-testing in each directory + UNDERWAY - fix all resulting compile errors! + +* Fix Broken Unit-test for COSS + + stub time| COSS block-size = 512 bytes + stub time| COSS largest file offset = -1 KB + stub time| COSS cache_dir size = 102400 KB + stub time| Fatal: COSS cache_dir size exceeds largest offset + .FAIL: tests/testCoss + ================================================= + 1 of 16 tests failed + + +* Obsolete typedefs.h + - remove all unneeded typedefs + - move all needed typedefs to their appropriate headers + - fix all resulting compile errors + +* Obsolete protos.h + - move all protos to their appropriate header files + - add includes for headers where needed. + +* Obsolete structs.h + - move all structs to their appropriate header files + - move modular configuration in to *Config.h files + (discussion on exactly what the modules are) + +* Auto-doc the API for modules decided above + +* Move files into appropriate sub-dirs based on modules + --- squid3/NOTES-cleanup Sat Feb 23 01:23:02 2008 +++ /dev/null Sat Feb 23 01:23:02 2008 @@ -1,37 +0,0 @@ - -TODO List for the cleanup branch operations. - -* Add automatic testing for header dependency - DONE- script to perform universal include unit-test for .h files - UNDERWAY - link to automatic unit-testing in each directory - UNDERWAY - fix all resulting compile errors! - -* Fix Broken Unit-test for COSS - - stub time| COSS block-size = 512 bytes - stub time| COSS largest file offset = -1 KB - stub time| COSS cache_dir size = 102400 KB - stub time| Fatal: COSS cache_dir size exceeds largest offset - .FAIL: tests/testCoss - ================================================= - 1 of 16 tests failed - - -* Obsolete typedefs.h - - remove all unneeded typedefs - - move all needed typedefs to their appropriate headers - - fix all resulting compile errors - -* Obsolete protos.h - - move all protos to their appropriate header files - - add includes for headers where needed. - -* Obsolete structs.h - - move all structs to their appropriate header files - - move modular configuration in to *Config.h files - (discussion on exactly what the modules are) - -* Auto-doc the API for modules decided above - -* Move files into appropriate sub-dirs based on modules - Index: squid3/src/Makefile.am =================================================================== RCS file: /cvsroot/squid-sf//squid3/src/Makefile.am,v retrieving revision 1.138.2.5 retrieving revision 1.138.2.6 diff -u -r1.138.2.5 -r1.138.2.6 --- squid3/src/Makefile.am 20 Feb 2008 11:38:44 -0000 1.138.2.5 +++ squid3/src/Makefile.am 22 Feb 2008 21:28:28 -0000 1.138.2.6 @@ -1,7 +1,7 @@ # # Makefile for the Squid Object Cache server # -# $Id: Makefile.am,v 1.138.2.5 2008/02/20 11:38:44 amosjeffries Exp $ +# $Id: Makefile.am,v 1.138.2.6 2008/02/22 21:28:28 amosjeffries Exp $ # # Uncomment and customize the following to suit your needs: # @@ -1168,8 +1168,12 @@ ## Special Universal .h dependency test script ## aborts if error encountered -testHeaders: *.h +testHeaders: *.h DiskIO/*.h ICAP/*.h ../test-suite/testheaders.sh "$(CXXCOMPILE)" "." || exit 1 + ../test-suite/testheaders.sh "$(CXXCOMPILE)" "DiskIO" || exit 1 + ../test-suite/testheaders.sh "$(CXXCOMPILE)" "ICAP" || exit 1 +## src/repl/ has no .h files and its own makefile. + ### Template for new Unit Test Program ## - add tests/testX to check_PROGRAMS above. Index: squid3/src/repl/Makefile.am =================================================================== RCS file: /cvsroot/squid-sf//squid3/src/repl/Makefile.am,v retrieving revision 1.6 retrieving revision 1.6.42.1 diff -u -r1.6 -r1.6.42.1 --- squid3/src/repl/Makefile.am 21 Aug 2005 02:13:15 -0000 1.6 +++ squid3/src/repl/Makefile.am 22 Feb 2008 21:28:28 -0000 1.6.42.1 @@ -1,6 +1,6 @@ # Makefile for storage modules in the Squid Object Cache server # -# $Id: Makefile.am,v 1.6 2005/08/21 02:13:15 squidadm Exp $ +# $Id: Makefile.am,v 1.6.42.1 2008/02/22 21:28:28 amosjeffries Exp $ # AUTOMAKE_OPTIONS = subdir-objects @@ -18,3 +18,11 @@ INCLUDES = -I. -I$(top_builddir)/include -I$(top_srcdir)/include \ -I$(top_srcdir)/src +check_PROGRAMS= testHeaders + +## Special Universal .h dependency test script +## aborts if error encountered +testHeaders: heap/*.h + $(top_srcdir)/test-suite/testheaders.sh "$(CXXCOMPILE)" "heap" || exit 1 +## ./ has no .h files. +## ./lru/ has no .h files.