---------------------
PatchSet 4676 
Date: 2007/05/31 10:51:04
Author: amosjeffries
Branch: squid3-ipv6
Tag: (none) 
Log:
Drop debug lines no longer needed. Update known bug NOTES.

Members: 
	NOTES-IPv6:1.1.2.28->1.1.2.29 
	src/comm.cc:1.47.2.32->1.47.2.33 

Index: squid3/NOTES-IPv6
===================================================================
RCS file: /cvsroot/squid-sf//squid3/Attic/NOTES-IPv6,v
retrieving revision 1.1.2.28
retrieving revision 1.1.2.29
diff -u -r1.1.2.28 -r1.1.2.29
--- squid3/NOTES-IPv6	31 May 2007 10:39:07 -0000	1.1.2.28
+++ squid3/NOTES-IPv6	31 May 2007 10:51:04 -0000	1.1.2.29
@@ -1,4 +1,4 @@
-$Id: NOTES-IPv6,v 1.1.2.28 2007/05/31 10:39:07 amosjeffries Exp $
+$Id: NOTES-IPv6,v 1.1.2.29 2007/05/31 10:51:04 amosjeffries Exp $
 
 KNOWN BUGS:
 
@@ -8,23 +8,17 @@
           Solved for all known events now, but this may reccur at any time
           until conversion is completed.
 
-PROBLEM: (side effect of solved SPLIT-STACK configure bug, needs re-testing.)
-2007/05/29 01:25:13.965| fwdConnectStart: got addr [::], tos 0
-2007/05/29 01:25:13.965| comm_open: setsockopt(IPV6_V6ONLY) on FD 13: (92) Protocol not available
-2007/05/29 01:25:13.965| comm_open: FD 13 is a new socket
-
-
-PROBLEM: DNS (IPv6-only) getHostname lookup fails
-2007/05/29 02:27:33.085| idnsAddNameserver: Added nameserver #0 ([2002:3cea:e96f:0:2e0:18ff:febb:b02e]:53)
-2007/05/29 02:27:33.085| idnsAddNameserver: Added nameserver #1 ([2001:5c0:9388:0:2e0:18ff:febb:b02e]:53)
-2007/05/29 02:27:33.567| idnsALookup: buf is 37 bytes for proxy.treenet.co.nz, id = 0xa9ec
-2007/05/29 02:27:33.567| idnsSendQuery: FD 7: sendto: (97) Address family not supported by protocol
-2007/05/29 02:27:33.567| idnsSendQuery: FD 7: sendto: (97) Address family not supported by protocol
-LOCATION: src/tools.cc:605
-ADDITIONAL: (adding dst IP:port to debug display)
-2007/05/30 01:35:42.284| idnsCheckQueue: ID 0x76e7timeout
-2007/05/30 01:35:42.284| comm_udp_sendto: FD 7, [2002:3cea:e96f:0:2e0:18ff:febb:b02e]:53: (97) Address family not supported by protocol
-2007/05/30 01:35:42.284| comm_udp_sendto: FD 7, [2001:5c0:9388:0:2e0:18ff:febb:b02e]:53: (97) Address family not supported by protocol
+
+PROBLEM: connection to parent proxy fails:
+
+2007/05/31 22:36:02.741| ConnectSateData::connect: to 192.168.0.14:3128
+2007/05/31 22:36:02.741| commConnectCallback: FD 16, data 0x855bab8
+2007/05/31 22:36:02.741| comm_remove_close_handler: FD 16, handler=1, data=0x856feb0
+2007/05/31 22:36:02.741| commSetTimeout: FD 16 timeout -1
+2007/05/31 22:36:02.741| fwdFail: ERR_CONNECT_FAIL "Service Unavailable"
+2007/05/31 22:36:02.741| TCP connection to proxy.treenet.co.nz/3128 failed
+2007/05/31 22:36:02.741| TCP connection to proxy.treenet.co.nz/3128 dead
+2007/05/31 22:36:02.741| comm_close: FD 16
 
 
 cache.log lines detected showing problems:
Index: squid3/src/comm.cc
===================================================================
RCS file: /cvsroot/squid-sf//squid3/src/comm.cc,v
retrieving revision 1.47.2.32
retrieving revision 1.47.2.33
diff -u -r1.47.2.32 -r1.47.2.33
--- squid3/src/comm.cc	31 May 2007 10:39:09 -0000	1.47.2.32
+++ squid3/src/comm.cc	31 May 2007 10:51:06 -0000	1.47.2.33
@@ -1,6 +1,6 @@
 
 /*
- * $Id: comm.cc,v 1.47.2.32 2007/05/31 10:39:09 amosjeffries Exp $
+ * $Id: comm.cc,v 1.47.2.33 2007/05/31 10:51:06 amosjeffries Exp $
  *
  * DEBUG: section 5     Socket Functions
  * AUTHOR: Harvest Derived
@@ -887,9 +887,7 @@
     AI->ai_protocol = proto;
     AI->ai_flags = flags;
 
-    debugs(50, 3, "comm_openex: Attempt open socket to/from : " << addr);
-    debugs(50, 3, "AYJ: protocol=" << AI->ai_protocol << " WANT=" << IPPROTO_TCP << " or " << IPPROTO_UDP );
-    debugs(50, 3, "AYJ: protocol=" << AI->ai_socktype << " WANT=" << SOCK_STREAM);
+    debugs(50, 3, "comm_openex: Attempt open socket to/on : " << addr);
 
     if ((new_socket = socket( AI->ai_family, AI->ai_socktype, AI->ai_protocol)) < 0)
     {
@@ -1651,24 +1649,20 @@
     int x = 0;
     struct addrinfo *AI = new addrinfo;
 
-    to_addr.GetAddrInfo(*AI); // MUST be first! resets AI.
-// Hmm, these details are never used from here on!
-    AI->ai_protocol = IPPROTO_UDP;
-    AI->ai_socktype = SOCK_DGRAM;
-
     PROF_start(comm_udp_sendto);
     statCounter.syscalls.sock.sendtos++;
 
-    debugs(50, 3, "comm_udp_sendto: Attempt open socket to/from : " << to_addr);
-    debugs(50, 3, "AYJ: using FD " << fd << " using Port " << comm_local_port(fd) );
-    debugs(50, 3, "AYJ: protocol=" << AI->ai_protocol << " WANT=" << IPPROTO_UDP );
-    debugs(50, 3, "AYJ: socktype=" << AI->ai_socktype << " WANT=" << SOCK_DGRAM);
+    to_addr.GetAddrInfo(*AI); // MUST be first! resets AI.
+
+    debugs(50, 3, "comm_udp_sendto: Attempt to send UDP packet to " << to_addr <<
+                  " using FD " << fd << " using Port " << comm_local_port(fd) );
 
     x = sendto(fd, buf, len, 0, (struct sockaddr *)AI->ai_addr, AI->ai_addrlen);
-    PROF_stop(comm_udp_sendto);
 
     freeaddrinfo(AI);
 
+    PROF_stop(comm_udp_sendto);
+
     if (x >= 0)
         return x;