---------------------
PatchSet 4663 
Date: 2007/05/29 00:09:49
Author: amosjeffries
Branch: squid3-ipv6
Tag: (none) 
Log:
Add debugging to catch squid.conf parsing dies in ACLIP (v6)

Members: 
	NOTES-IPv6:1.1.2.24->1.1.2.25 
	src/ACLIP.cc:1.8.2.26->1.8.2.27 

Index: squid3/NOTES-IPv6
===================================================================
RCS file: /cvsroot/squid-sf//squid3/Attic/NOTES-IPv6,v
retrieving revision 1.1.2.24
retrieving revision 1.1.2.25
diff -u -r1.1.2.24 -r1.1.2.25
--- squid3/NOTES-IPv6	28 May 2007 14:31:46 -0000	1.1.2.24
+++ squid3/NOTES-IPv6	29 May 2007 00:09:49 -0000	1.1.2.25
@@ -1,4 +1,4 @@
-$Id: NOTES-IPv6,v 1.1.2.24 2007/05/28 14:31:46 amosjeffries Exp $
+$Id: NOTES-IPv6,v 1.1.2.25 2007/05/29 00:09:49 amosjeffries Exp $
 
 KNOWN BUGS:
 
@@ -24,6 +24,11 @@
 2007/05/29 02:27:33.567| idnsSendQuery: FD 7: sendto: (97) Address family not supported by protocol
 LOCATION: src/tools.cc:605
 
+PROBLEM:
+  acl our_networks_v6 2404:130:b1ff::/48
+  But on running squid3 I get this error message:
+  FATAL: Bungled squid3.conf line 2398: acl our_networks_v6 src 2404:130:b1ff::/48
+LOCATION: ACLIP.cc: 276
 
 .... cache.log lines detected showing problems:
      (after a request for http://[2001:200:0:8002:203:47ff:fea5:3085]/ )
Index: squid3/src/ACLIP.cc
===================================================================
RCS file: /cvsroot/squid-sf//squid3/src/ACLIP.cc,v
retrieving revision 1.8.2.26
retrieving revision 1.8.2.27
diff -u -r1.8.2.26 -r1.8.2.27
--- squid3/src/ACLIP.cc	29 Apr 2007 05:47:32 -0000	1.8.2.26
+++ squid3/src/ACLIP.cc	29 May 2007 00:09:49 -0000	1.8.2.27
@@ -1,5 +1,5 @@
 /*
- * $Id: ACLIP.cc,v 1.8.2.26 2007/04/29 05:47:32 amosjeffries Exp $
+ * $Id: ACLIP.cc,v 1.8.2.27 2007/05/29 00:09:49 amosjeffries Exp $
  *
  * DEBUG: section 28    Access Control
  * AUTHOR: Duane Wessels
@@ -137,11 +137,11 @@
 
     } else {                   /* range address check */
 
-	if ( (A >= q->addr1) && (A <= q->addr2) )
-		return 0; /* valid */
-	else
-		return A.matchIPAddr( q->addr1 ); /* outside of range, 'less than' */
-     }
+        if ( (A >= q->addr1) && (A <= q->addr2) )
+            return 0; /* valid */
+        else
+            return A.matchIPAddr( q->addr1 ); /* outside of range, 'less than' */
+    }
 }
 
 
@@ -309,18 +309,21 @@
             case AF_INET:
                 {
                     r->addr1 = *( (struct in_addr*)*x );
+                    debugs(28, 3, "aclParseIpData: Located host/IP: '" << r->addr1 << "'");
                 } break;
 
             case AF_INET6:
                 {
 #if USE_IPV6
                     r->addr1 = *( (struct in6_addr*)*x );
+                    debugs(28, 3, "aclParseIpData: Located host/IP: '" << r->addr1 << "'");
 #else
-                    // Drop the IPv6 Address
+                    debugs(28, 1, "WARNING: aclParseIpData: Dropping IPv6 host/IP: '" << l_addr1 << "'");
 #endif
                 } break;
 
             default:
+                debugs(28, 1, "WARNING: aclParseIpData: Defaulting host/IP: '" << l_addr1 << "' to ANY.");
                 r->addr1.SetAnyAddr();
             }