--------------------- PatchSet 6053 Date: 2003/11/24 15:51:10 Author: rhorstmann Branch: icap-2_5 Tag: (none) Log: When calling httpStateFree from icap, fd might be -1. With delay pools enabled, delayClearNoDelay segfaults then. So check fd here before calling it. Members: src/http.c:1.17.6.3.6.18->1.17.6.3.6.19 Index: squid/src/http.c =================================================================== RCS file: /cvsroot/squid-sf//squid/src/http.c,v retrieving revision 1.17.6.3.6.18 retrieving revision 1.17.6.3.6.19 diff -u -r1.17.6.3.6.18 -r1.17.6.3.6.19 --- squid/src/http.c 11 Nov 2003 23:29:25 -0000 1.17.6.3.6.18 +++ squid/src/http.c 24 Nov 2003 15:51:10 -0000 1.17.6.3.6.19 @@ -1,6 +1,6 @@ /* - * $Id: http.c,v 1.17.6.3.6.18 2003/11/11 23:29:25 dwsquid Exp $ + * $Id: http.c,v 1.17.6.3.6.19 2003/11/24 15:51:10 rhorstmann Exp $ * * DEBUG: section 11 Hypertext Transfer Protocol (HTTP) * AUTHOR: Harvest Derived @@ -60,7 +60,8 @@ { HttpStateData *httpState = data; #if DELAY_POOLS - delayClearNoDelay(fd); + if (fd >= 0) + delayClearNoDelay(fd); #endif if (httpState == NULL) return;