---------------------
PatchSet 2955 
Date: 2001/09/04 11:30:55
Author: rbcollins
Branch: ntlm
Tag: (none) 
Log:
Added TODO's for the case when a stateful helper dies unexpectedly

Members: 
	src/helper.c:1.1.1.3.12.41->1.1.1.3.12.42 
	src/auth/ntlm/auth_ntlm.c:1.1.10.14.2.51->1.1.10.14.2.52 

Index: squid/src/helper.c
===================================================================
RCS file: /cvsroot/squid-sf//squid/src/helper.c,v
retrieving revision 1.1.1.3.12.41
retrieving revision 1.1.1.3.12.42
diff -u -r1.1.1.3.12.41 -r1.1.1.3.12.42
--- squid/src/helper.c	1 Sep 2001 12:22:42 -0000	1.1.1.3.12.41
+++ squid/src/helper.c	4 Sep 2001 11:30:55 -0000	1.1.1.3.12.42
@@ -1,6 +1,6 @@
 
 /*
- * $Id: helper.c,v 1.1.1.3.12.41 2001/09/01 12:22:42 rbcollins Exp $
+ * $Id: helper.c,v 1.1.1.3.12.42 2001/09/04 11:30:55 rbcollins Exp $
  *
  * DEBUG: section 29    Helper process maintenance
  * AUTHOR: Harvest Derived?
@@ -670,6 +670,7 @@
 	helperStatefulRequestFree(r);
 	srv->request = NULL;
     }
+    /* TODO: walk the local queue of requests and carry them all out */
     if (srv->wfd != srv->rfd && srv->wfd != -1)
 	comm_close(srv->wfd);
     dlinkDelete(&srv->link, &hlp->servers);
Index: squid/src/auth/ntlm/auth_ntlm.c
===================================================================
RCS file: /cvsroot/squid-sf//squid/src/auth/ntlm/auth_ntlm.c,v
retrieving revision 1.1.10.14.2.51
retrieving revision 1.1.10.14.2.52
diff -u -r1.1.10.14.2.51 -r1.1.10.14.2.52
--- squid/src/auth/ntlm/auth_ntlm.c	4 Sep 2001 10:31:52 -0000	1.1.10.14.2.51
+++ squid/src/auth/ntlm/auth_ntlm.c	4 Sep 2001 11:30:55 -0000	1.1.10.14.2.52
@@ -443,6 +443,9 @@
     } 
     
     if (!reply) {
+        /* TODO: this occurs when a helper crashes. We should clean up that helpers resources
+	 * and queued requests.
+	 */
 	fatal("authenticateNTLMHandleReply: called with no result string\n");
     }