--------------------- PatchSet 4400 Date: 2007/04/28 00:16:06 Author: rousskov Branch: squid3-icap Tag: (none) Log: Disable transaction retries if we are not using a persistent connection. ICAP does not talk about retrying failures other than pconn race conditions. It might be OK to retry other failures, but I have not done the required analysis and am not going to do that in the foreseeable future. For example, other failures may need other conditions for disabling retries (current code should disable retries when the first response byte is read). Members: src/ICAP/ICAPXaction.cc:1.1.2.15->1.1.2.16 Index: squid3/src/ICAP/ICAPXaction.cc =================================================================== RCS file: /cvsroot/squid-sf//squid3/src/ICAP/ICAPXaction.cc,v retrieving revision 1.1.2.15 retrieving revision 1.1.2.16 diff -u -r1.1.2.15 -r1.1.2.16 --- squid3/src/ICAP/ICAPXaction.cc 25 Apr 2007 22:03:10 -0000 1.1.2.15 +++ squid3/src/ICAP/ICAPXaction.cc 28 Apr 2007 00:16:06 -0000 1.1.2.16 @@ -118,6 +118,8 @@ true); return; } + + disableRetries(); // we only retry pconn failures } connection = comm_open(SOCK_STREAM, 0, getOutgoingAddr(NULL), 0,