--------------------- PatchSet 4144 Date: 2007/04/03 15:10:32 Author: rousskov Branch: squid3-icap Tag: (none) Log: - Call storeEntry()->complete() when ending request satisfaction. Without this call, we may keep the connection open, which does not work with responses that mark the end of their body by closing a connection. (Christos Tsantilas) Members: src/client_side_request.cc:1.34.4.27->1.34.4.28 Index: squid3/src/client_side_request.cc =================================================================== RCS file: /cvsroot/squid-sf//squid3/src/client_side_request.cc,v retrieving revision 1.34.4.27 retrieving revision 1.34.4.28 diff -u -r1.34.4.27 -r1.34.4.28 --- squid3/src/client_side_request.cc 21 Mar 2007 20:05:14 -0000 1.34.4.27 +++ squid3/src/client_side_request.cc 3 Apr 2007 15:10:32 -0000 1.34.4.28 @@ -1,6 +1,6 @@ /* - * $Id: client_side_request.cc,v 1.34.4.27 2007/03/21 20:05:14 rousskov Exp $ + * $Id: client_side_request.cc,v 1.34.4.28 2007/04/03 15:10:32 rousskov Exp $ * * DEBUG: section 85 Client-side Request Routines * AUTHOR: Robert Collins (Originally Duane Wessels in client_side.c) @@ -1185,11 +1185,12 @@ void ClientHttpRequest::endRequestSatisfaction() { + debugs(85,4, HERE << this << " ends request satisfaction"); assert(request_satisfaction_mode); stopConsumingFrom(icapBodySource); - // XXX: how to end store entry formation correctly? - debugs(85,2, HERE << this << " does not seem to end request satisfaction"); + // TODO: anything else needed to end store entry formation correctly? + storeEntry()->complete(); } void