--------------------- PatchSet 3881 Date: 2006/10/25 22:22:44 Author: rousskov Branch: squid3-icap Tag: (none) Log: - Use validated_cbdata when calling back after validating callback_data. Using callback_data leads to segfaults because it is NULL. Members: src/ICAP/ICAPConfig.cc:1.1.2.4->1.1.2.5 Index: squid3/src/ICAP/ICAPConfig.cc =================================================================== RCS file: /cvsroot/squid-sf//squid3/src/ICAP/ICAPConfig.cc,v retrieving revision 1.1.2.4 retrieving revision 1.1.2.5 diff -u -r1.1.2.4 -r1.1.2.5 --- squid3/src/ICAP/ICAPConfig.cc 25 Oct 2006 17:45:00 -0000 1.1.2.4 +++ squid3/src/ICAP/ICAPConfig.cc 25 Oct 2006 22:22:44 -0000 1.1.2.5 @@ -1,6 +1,6 @@ /* - * $Id: ICAPConfig.cc,v 1.1.2.4 2006/10/25 17:45:00 rousskov Exp $ + * $Id: ICAPConfig.cc,v 1.1.2.5 2006/10/25 22:22:44 rousskov Exp $ * * SQUID Web Proxy Cache http://www.squid-cache.org/ * ---------------------------------------------------------- @@ -271,7 +271,7 @@ service = findFirstService(theClass, false); if (!service) - callback(NULL, callback_data); + callback(NULL, validated_cbdata); else callback(service, validated_cbdata); }