--------------------- PatchSet 1600 Date: 2005/08/24 23:34:23 Author: rousskov Branch: squid3-icap Tag: (none) Log: - Added a comment regarding possible reply leak at the top of processReplyHeader(). Members: src/http.cc:1.49.2.14->1.49.2.15 Index: squid3/src/http.cc =================================================================== RCS file: /cvsroot/squid-sf//squid3/src/http.cc,v retrieving revision 1.49.2.14 retrieving revision 1.49.2.15 diff -u -r1.49.2.14 -r1.49.2.15 --- squid3/src/http.cc 24 Aug 2005 22:50:29 -0000 1.49.2.14 +++ squid3/src/http.cc 24 Aug 2005 23:34:23 -0000 1.49.2.15 @@ -1,6 +1,6 @@ /* - * $Id: http.cc,v 1.49.2.14 2005/08/24 22:50:29 dwsquid Exp $ + * $Id: http.cc,v 1.49.2.15 2005/08/24 23:34:23 rousskov Exp $ * * DEBUG: section 11 Hypertext Transfer Protocol (HTTP) * AUTHOR: Harvest Derived @@ -691,7 +691,8 @@ HttpStateData::processReplyHeader(const char *buf, int size) { /* Creates a blank header. If this routine is made incremental, this will - * not do + * not do. XXX: is not this routine called more than once if we do not + * have enough buffered data to parse the header? Leaking "reply"s? */ reply = httpReplyCreate(); Ctx ctx = ctx_enter(entry->mem_obj->url);