---------------------
PatchSet 1415 
Date: 2005/05/24 01:22:11
Author: nlewycky
Branch: prefetching
Tag: (none) 
Log:
Fix for brokenness like "<img src>".
Sadly, this was found in the real world.

Members: 
	src/HTMLAnalysisStream.cc:1.1.2.6->1.1.2.7 

Index: squid3/src/HTMLAnalysisStream.cc
===================================================================
RCS file: /cvsroot/squid-sf//squid3/src/Attic/HTMLAnalysisStream.cc,v
retrieving revision 1.1.2.6
retrieving revision 1.1.2.7
diff -u -r1.1.2.6 -r1.1.2.7
--- squid3/src/HTMLAnalysisStream.cc	11 May 2005 16:33:46 -0000	1.1.2.6
+++ squid3/src/HTMLAnalysisStream.cc	24 May 2005 01:22:11 -0000	1.1.2.7
@@ -1,6 +1,6 @@
 
 /*
- * $Id: HTMLAnalysisStream.cc,v 1.1.2.6 2005/05/11 16:33:46 nlewycky Exp $
+ * $Id: HTMLAnalysisStream.cc,v 1.1.2.7 2005/05/24 01:22:11 nlewycky Exp $
  *
  * DEBUG: section 93    HTML parsing and fetching
  * AUTHOR: Nick Lewycky
@@ -119,9 +119,9 @@
 
     relative_url = urlCanonicalClean(request);
 
-    debugs(93, 3, "depth: " << request->recursion_depth);
+    debugs(93, 5, "(AS) depth: " << request->recursion_depth);
 
-    debugs(93, 4, "analyzing " << relative_url);
+    debugs(93, 4, "(AS) analyzing " << relative_url);
 }
 
 HTMLAnalysisStream::~HTMLAnalysisStream()
@@ -159,8 +159,8 @@
     // <img src="foo.png">
     if (strcasecmp(name, "img") == 0) {
         while (*attr) {
-            if (strcasecmp(*attr, "src") == 0) {
-              self->prefetch(*(attr + 1), false);
+            if (strcasecmp(*attr, "src") == 0 && *(attr + 1)) {
+                self->prefetch(*(attr + 1), false);
                 return;
             }
 
@@ -175,8 +175,8 @@
     // <iframe src="foo.html">
     if (strcasecmp(name, "frame") == 0 || strcasecmp(name, "iframe") == 0) {
         while (*attr) {
-            if (strcasecmp(*attr, "src") == 0) {
-              self->prefetch(*(attr + 1), true);
+            if (strcasecmp(*attr, "src") == 0 && *(attr + 1)) {
+                self->prefetch(*(attr + 1), true);
                 return;
             }
 
@@ -193,7 +193,7 @@
     string href;
     if (strcasecmp(name, "link") == 0) {
         while (*attr) {
-            if (strcasecmp(*attr, "href") == 0) {
+            if (strcasecmp(*attr, "href") == 0 && *(attr + 1)) {
                 if (is_fetchable) {
                     self->prefetch(*(attr + 1), true);
                     return;
@@ -223,7 +223,7 @@
 
     if (strcasecmp(name, "meta") == 0) {
         while (*attr) {
-            if (strcasecmp(*attr, "content") == 0) {
+            if (strcasecmp(*attr, "content") == 0 && *(attr + 1)) {
                 // TODO: replace this with some incantation of httpHeaderParse?
 
                 /* From RFC 2068:
@@ -355,7 +355,7 @@
     // <base href="http://www.example.com/foo/">
     if (strcasecmp(name, "base") == 0) {
         while (*attr) {
-            if (strcasecmp(*attr, "href") == 0) {
+            if (strcasecmp(*attr, "href") == 0 && *(attr + 1)) {
                 self->relative_url = *(attr + 1);
                 return;
             }