--------------------- PatchSet 6520 Date: 2005/03/18 16:45:35 Author: hno Branch: ssl-2_5 Tag: (none) Log: Plug memory leaks in certificate based ACLs Members: src/ssl_support.c:1.6.6.1.2.14->1.6.6.1.2.15 Index: squid/src/ssl_support.c =================================================================== RCS file: /cvsroot/squid-sf//squid/src/ssl_support.c,v retrieving revision 1.6.6.1.2.14 retrieving revision 1.6.6.1.2.15 diff -u -r1.6.6.1.2.14 -r1.6.6.1.2.15 --- squid/src/ssl_support.c 12 Feb 2005 11:16:59 -0000 1.6.6.1.2.14 +++ squid/src/ssl_support.c 18 Mar 2005 16:45:35 -0000 1.6.6.1.2.15 @@ -860,6 +860,7 @@ { X509 *cert; X509_NAME *name; + const char *ret; if (!ssl) return NULL; @@ -868,11 +869,14 @@ if (!cert) return NULL; - X509_free(cert); - name = X509_get_subject_name(cert); - return ssl_get_attribute(name, attribute_name); + ret = ssl_get_attribute(name, attribute_name); + + X509_free(cert); + CRYPTO_free(name); + + return ret; } const char * @@ -880,6 +884,7 @@ { X509 *cert; X509_NAME *name; + const char *ret; if (!ssl) return NULL; @@ -888,11 +893,14 @@ if (!cert) return NULL; - X509_free(cert); - name = X509_get_issuer_name(cert); - return ssl_get_attribute(name, attribute_name); + ret = ssl_get_attribute(name, attribute_name); + + X509_free(cert); + CRYPTO_free(name); + + return ret; } #if 0